Plugins: Preserve trailing slash in plugin proxy #86859
Conversation
marefr
requested review from
wbrowne,
andresmgot and
xnyo
and removed request for
a team
pkg/services/featuremgmt/registry.go
Outdated
| { | ||
| Name: "pluginProxyPreserveTrailingSlash", | ||
| Description: "Preserve plugin proxy trailing slash.", | ||
| Stage: FeatureStageExperimental, |
There was a problem hiding this comment.
Instead of an experimental feature that needs to be turned on, could we consider this a bug fix?
There was a problem hiding this comment.
Agree, because otherwise we can never turn it on. Since we can never be certain which plugins it may affect.
There was a problem hiding this comment.
You can add Expression: "true" to enable it by default. In case of error, it's easier to change a flag than rolling back or pinning instances so it's safer this way.
There was a problem hiding this comment.
It's enabled by default now
|
Since this is a bug fix, can we backport it into the previous version? That would allow us to leverage the fix in cloud without having to wait a month for the slow channel to roll out. |
pkg/services/featuremgmt/registry.go
Outdated
| { | ||
| Name: "pluginProxyPreserveTrailingSlash", | ||
| Description: "Preserve plugin proxy trailing slash.", | ||
| Stage: FeatureStageExperimental, |
There was a problem hiding this comment.
You can add Expression: "true" to enable it by default. In case of error, it's easier to change a flag than rolling back or pinning instances so it's safer this way.
Cloud does not work with versions. Even if backported you would still need to wait a month for the fix to reach the slow channel. I don't think we need to backport this but up to you. |
Interesting, How do we get urgent fixes out to cloud then? |
I believe there is a process to request |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions! |
|
ping @marefr if you want to update/merge this. |
|
@andresmgot made it default true. Wasn't sure about the stage, but went with |
Fix to allow preserving trailing slash in plugin proxy if the incoming URL contains a trailing slash. Behind feature toggle since unsure if this could cause issue for existing app plugins.
Fixes #86851