DashboardDataSourceBehaviour: Handle loading library panel #86980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dprokop
added
type/bug
no-changelog
dprokop
requested review from
ivanortegaalba and
Sergej-Vlasov
and removed request for
a team
|
This PR must be merged before a backport PR will be created. |
1 similar comment
|
This PR must be merged before a backport PR will be created. |
dprokop
commented
Apr 26, 2024
| @@ -83,7 +83,7 @@ export class LibraryVizPanel extends SceneObjectBase<LibraryVizPanelState> { | |||
|
|
|||
| private async loadLibraryPanelFromPanelModel() { | |||
| let vizPanel = this.state.panel!; | |||
|
|
|||
| await new Promise((f) => setTimeout(f, 1000)); | |||
There was a problem hiding this comment.
Suggested change
| await new Promise((f) => setTimeout(f, 1000)); |
Was here to simulate slow loading time
axelavargas
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
🙌🏾 great job, @dprokop , the code looks great, I also gave a quick test locally, works as expected.
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
* DashboardDataSourceBehaviour: Handle loading library panel * Remove timeout * FIx test (cherry picked from commit 67968df)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86966
https://raintank-corp.slack.com/archives/C03MCTKAJA0/p1714062157912579
The problem was that LibraryVizPanel loads source panel asynchroniously and can only set internal VizPanel's SceneQueryRunner when the panel is resolved. The behavior did not account for that throwing early as it couldn't find the corresponding query runner that indicates readiness for dashboard query execution.