Chore: Add tracing to team service #86999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IevaVasiljeva
added
no-backport
mgyongyosi
reviewed
Apr 29, 2024
pkg/services/team/teamimpl/team.go
Outdated
| } | ||
|
|
||
| func (s *Service) CreateTeam(name, email string, orgID int64) (team.Team, error) { | ||
| _, span := s.tracer.Start(context.Background(), "team.CreateTeam", trace.WithAttributes( |
There was a problem hiding this comment.
I think this and the IsTeamMember functions would create a new root span (because the context is not propagated). I'm not 100% sure, but the current context should be passed to those functions to have proper tracing. Wdyt?
It can be also handled in a follow up PR.
There was a problem hiding this comment.
Thanks for pointing it out. I was putting it off as CreateTeam is used in soooo many tests but otherwise only from the team creation API function, so it felt like a lot of work for no benefit (as no useful context would be propagated for any non-test code execution path). But now that I see the amount of test changes that are required for ProvideService anyway, I might as well add a few more 😄
mgyongyosi
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Adds tracing to team service.
Enterprise PR: https://github.com/grafana/grafana-enterprise/pull/6546
Related to https://github.com/grafana/identity-access-team/issues/601