ShareModal: Share link redesign under newDashboardSharingComponent FF
#87011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanicabanas
requested review from
mdvictor,
kaydelaney,
joshhunt,
JoaoSilvaGrafana,
evictorero,
AgnesToulet and
lucychen-grafana
and removed request for
a team
juanicabanas
added
no-backport
AgnesToulet
reviewed
May 3, 2024
Comment on lines
118
to
120
| expect(screen.queryByTestId(selectors.pages.Dashboard.DashNav.shareButton)).not.toBeInTheDocument(); | ||
| const newShareButton = await screen.findByTestId(selectors.pages.Dashboard.DashNav.newShareButton.container); | ||
| expect(newShareButton).toBeInTheDocument(); |
There was a problem hiding this comment.
Out of curiosity:
- Why are we using
screen.queryByTestId(selectors.pages.Dashboard.DashNav.shareButton)instead ofscreen.findByText('Share')as above to retrieve the old share button? - Why are we using
findByTestIdinstead ofqueryByTestIdas above to retrieve the new share button?
There was a problem hiding this comment.
- It's common to change the button text (and in this test, we're not testing that the button has "Share" text). Therefore, the test would fail. Actually, in the middle of the PR I changed "Share Link" to "Share" and the test failed when I was testing another thing.
- FindBy is async. However, the component should be already mounted. I can change it
| toolbarActions.push({ | ||
| group: 'new-share-dashboard-button', | ||
| condition: | ||
| config.featureToggles.newDashboardSharingComponent && uid && !isEditing && !meta.isSnapshot && !isPlaying, |
There was a problem hiding this comment.
Maybe this uid && !isEditing && !meta.isSnapshot && !isPlaying can be extracted into a variable to not be duplicated between the old and the new share buttons.
AgnesToulet
approved these changes
May 3, 2024
|
Yes, it is validated. The wording of the CTA needs to be changed to be only "Share" |
@natydej |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
newDashboardSharingComponentFF for share modal redesignWhy do we need this feature?
Part of #85240
Which issue(s) does this PR fix?:
Fixes #85241
Special notes for your reviewer:
new-share-button.mov