New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus: Add hints for native histograms #87017
base: main
Are you sure you want to change the base?
Conversation
A hint: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also encountering some issues:
demo.prometheus.native.histogram.hints.mov
Thanks, Ismail and Nick, for the review! Can I assume Brenden will be the one fixing these issues when he returns? |
Fixes #86388
What is this feature?
When a user selects a native histogram, a hint or hints should be provided indicating they have selected a native histogram and providing functions for that metric.
This PR provides hints that allow a user to add 6 functions to the query builder from a native histogram hint
The code editor can only show one hint at a time so until we refactor that, we show that the metric is a native histogram and provide the hint to use histogram_avg with the rate function.
Fixes #86388
Why do we need this feature?
Native histograms are being released in Mimir in the next month and this is part of the GA strategy.
Who is this feature for?
For users who have enabled native histograms.
Special notes for your reviewer:
TESTING!!!!!!
Now you should have a data source that has a native histogram. The native histogram is named
rpc_durations_native_histogram_seconds
.When you select this in the query builder you will get six query hints (6 functions).
When you select this metric in the code editor you will get one hint because the code editor only displays one hint. We need to fix that or create an issue to fix this.
Please check that: