Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User: Add tracing #87028

Merged
merged 4 commits into from Apr 30, 2024
Merged

User: Add tracing #87028

merged 4 commits into from Apr 30, 2024

Conversation

kalleep
Copy link
Contributor

@kalleep kalleep commented Apr 29, 2024

What is this feature?
Add tracing to user service. Most of the changes is just updates in tests.

Which issue(s) does this PR fix?:

Part of https://github.com/grafana/identity-access-team/issues/658

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@kalleep kalleep added the no-changelog Skip including change in changelog/release notes label Apr 29, 2024
@kalleep kalleep added this to the 11.1.x milestone Apr 29, 2024
@kalleep kalleep requested review from a team as code owners April 29, 2024 09:06
gamab
gamab approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@gamab gamab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One trace to rename :)

pkg/services/user/userimpl/user.go Outdated Show resolved Hide resolved
kalleep and others added 3 commits April 30, 2024 11:53
@kalleep
Inject tracer in tests
2290e72
@kalleep
Annotate with traces
d9e18ec
@kalleep @gamab
Update pkg/services/user/userimpl/user.go
4ca5f17 
Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
@kalleep kalleep merged commit a2cba3d into main Apr 30, 2024
12 checks passed
@kalleep kalleep deleted the user/tracing-annotation branch April 30, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gamab gamab gamab approved these changes

@ivanortegaalba ivanortegaalba Awaiting requested review from ivanortegaalba ivanortegaalba is a code owner automatically assigned from grafana/dashboards-squad

@Sergej-Vlasov Sergej-Vlasov Awaiting requested review from Sergej-Vlasov Sergej-Vlasov is a code owner automatically assigned from grafana/dashboards-squad

@rwwiv rwwiv Awaiting requested review from rwwiv rwwiv is a code owner automatically assigned from grafana/alerting-backend-product

@JacobsonMT JacobsonMT Awaiting requested review from JacobsonMT JacobsonMT is a code owner automatically assigned from grafana/alerting-backend-product

@yuri-tceretian yuri-tceretian Awaiting requested review from yuri-tceretian yuri-tceretian is a code owner automatically assigned from grafana/alerting-backend-product

@grobinson-grafana grobinson-grafana Awaiting requested review from grobinson-grafana grobinson-grafana is a code owner automatically assigned from grafana/alerting-backend-product

@diegommm diegommm Awaiting requested review from diegommm diegommm is a code owner automatically assigned from grafana/grafana-search-and-storage

Assignees
No one assigned
Labels
area/backend no-changelog Skip including change in changelog/release notes
Projects
None yet
Milestone
11.1.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kalleep @gamab