Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invisible character in SAML certificate command #87057

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

rjcrutch
Copy link
Contributor

Invisible character after nodes was preventing command from being properly copied and run.

Invisible character after `nodes` was preventing command from being properly copied and run
@rjcrutch rjcrutch requested a review from chri2547 as a code owner April 29, 2024 15:06
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone Apr 29, 2024
@rjcrutch rjcrutch added no-changelog Skip including change in changelog/release notes type/docs and removed type/docs labels Apr 29, 2024
Copy link
Collaborator

@chri2547 chri2547 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@rjcrutch
Copy link
Contributor Author

rjcrutch commented May 3, 2024

I re-ran the Drone CI and the build now passes, please merge at your earlier convenience.

Copy link
Contributor

github-actions bot commented Jun 3, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions!

@github-actions github-actions bot added the stale Issue with no recent activity label Jun 3, 2024
@jdbaldry jdbaldry merged commit 8fb12cd into main Jun 6, 2024
11 checks passed
@jdbaldry jdbaldry deleted the saml-cert-command-edit branch June 6, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Skip including change in changelog/release notes stale Issue with no recent activity type/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants