Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerting: Also fix HCL field name for MuteTimeIntervals #87079

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Alerting: Also fix HCL field name for MuteTimeIntervals #87079

merged 2 commits into from
Apr 30, 2024

Conversation

rwwiv
Copy link
Contributor

@rwwiv rwwiv commented Apr 29, 2024

What is this feature?

This PR is related to #87065, and corrects the HCL field name for mute time intervals.

Why do we need this feature?

Brings HCL export output in line with Terraform provider schema.

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@rwwiv rwwiv requested a review from a team as a code owner April 29, 2024 19:03
@rwwiv rwwiv requested review from JacobsonMT, yuri-tceretian and grobinson-grafana and removed request for a team April 29, 2024 19:03
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone Apr 29, 2024
yuri-tceretian
yuri-tceretian approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@yuri-tceretian yuri-tceretian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great catch!

@rwwiv rwwiv added type/bug area/alerting Grafana Alerting no-changelog Skip including change in changelog/release notes backport v11.0.x Mark PR for automatic backport to v11.0.x labels Apr 29, 2024
@grafana-delivery-bot grafana-delivery-bot
Copy link
Contributor

This PR must be merged before a backport PR will be created.

1 similar comment
@grafana-delivery-bot grafana-delivery-bot
Copy link
Contributor

This PR must be merged before a backport PR will be created.

@rwwiv rwwiv enabled auto-merge (squash) April 30, 2024 14:59
@rwwiv rwwiv merged commit 93519f7 into main Apr 30, 2024
13 checks passed
@rwwiv rwwiv deleted the rwwiv/nf-settings-hcl branch April 30, 2024 15:14
grafana-delivery-bot bot pushed a commit that referenced this pull request Apr 30, 2024
@rwwiv @grafana-delivery-bot
Alerting: Also fix HCL field name for MuteTimeIntervals (#87079)
f1a1705 
* Correct HCL field name for MuteTimeIntervals

* Update test

(cherry picked from commit 93519f7)
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request Apr 30, 2024
Merged
3 tasks
rwwiv added a commit that referenced this pull request May 6, 2024
@grafana-delivery-bot @rwwiv
[v11.0.x] Alerting: Also fix HCL field name for MuteTimeIntervals (#8…
d718929 
…7143)

Alerting: Also fix HCL field name for MuteTimeIntervals (#87079)

* Correct HCL field name for MuteTimeIntervals

* Update test

(cherry picked from commit 93519f7)

Co-authored-by: William Wernert <william.wernert@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuri-tceretian yuri-tceretian yuri-tceretian approved these changes

@JacobsonMT JacobsonMT Awaiting requested review from JacobsonMT JacobsonMT was automatically assigned from grafana/alerting-backend-product

@grobinson-grafana grobinson-grafana Awaiting requested review from grobinson-grafana grobinson-grafana was automatically assigned from grafana/alerting-backend-product

Assignees
No one assigned
Labels
area/alerting Grafana Alerting area/backend backport v11.0.x Mark PR for automatic backport to v11.0.x no-changelog Skip including change in changelog/release notes type/bug
Projects
Alerting
Status: Done
Milestone
11.1.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rwwiv @yuri-tceretian