DashboardScene: Fixes issue with panel edit options pane and data #87161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
requested review from
ivanortegaalba and
Sergej-Vlasov
and removed request for
a team
torkelo
added
type/bug
product-approved
|
This PR must be merged before a backport PR will be created. |
2 similar comments
|
This PR must be merged before a backport PR will be created. |
|
This PR must be merged before a backport PR will be created. |
axelavargas
added
the
no-changelog
Sergej-Vlasov
approved these changes
May 1, 2024
axelavargas
approved these changes
May 1, 2024
There was a problem hiding this comment.
🏅 The code looks good to me. I also gave it a quick test locally, it works as expected.
P.S. We need to add unit tests to this component (it does not need to be in this PR as the e2e POC (#84598) was the one that found the error)
dprokop
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87134
When I moved back the data to panel level I forgot to move this call to get data scoped from panel, so the panel option editors (And canvas option editor) got the global annotation queries instead.