-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Fix MatcherFilter onChange handling #87511
Conversation
This PR must be merged before a backport PR will be created. |
1 similar comment
This PR must be merged before a backport PR will be created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-87511-to-v11.0.x origin/v11.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x c203a030e8e6123b9abe5d580ea00a16aa81e0ba When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-87511-to-v11.0.x
# Create the PR body template
PR_BODY=$(gh pr view 87511 --json body --template 'Backport c203a030e8e6123b9abe5d580ea00a16aa81e0ba from #87511{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title "[v11.0.x] Alerting: Fix MatcherFilter onChange handling" --body-file - --label "type/bug" --label "area/alerting" --label "area/frontend" --label "no-changelog" --label "backport" --base v11.0.x --milestone 11.0.x --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-87511-to-v11.0.x
# Create a pull request where the `base` branch is `v11.0.x` and the `compare`/`head` branch is `backport-87511-to-v11.0.x`.
# Remove the local backport branch
git switch main
git branch -D backport-87511-to-v11.0.x |
No backport needed. v11.0 is not affected |
What is this feature?
This PR fixes
MatcherFilter
componentdebouce
function delays the invocation of the inner function and theevent
parameter gets changed between the event occurrence and actually calling the function resulting in undefined errorFixes #82044
Special notes for your reviewer:
Please check that: