Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DashboarScene: Fix hover header offset edge cases #87543

Closed
wants to merge 3 commits into from
Closed

DashboarScene: Fix hover header offset edge cases #87543

wants to merge 3 commits into from

Conversation

Sergej-Vlasov
Copy link
Contributor

With this PR I:

  • adjust hoverHeaderOffsetBehaviour to adjust panel menu offset in panel, library panel
  • add hoverHeaderOffsetBehavior to remaining DashboardGridItem's
  • adjust hoverHeaderOffset property when entering view pane and edit panel
  • adjust hoverHeaderOffset when editing panel title
  • add hoverHeader property when initiating LibraryVizPanel

Fixes #87495

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@Sergej-Vlasov Sergej-Vlasov added type/bug area/frontend no-changelog Skip including change in changelog/release notes area/scenes internal for issues made by grafanistas labels May 9, 2024
@Sergej-Vlasov Sergej-Vlasov added this to the 11.1.x milestone May 9, 2024
@Sergej-Vlasov Sergej-Vlasov self-assigned this May 9, 2024
@Sergej-Vlasov Sergej-Vlasov requested review from grafanabot and a team as code owners May 9, 2024 10:36
@Sergej-Vlasov Sergej-Vlasov requested review from mdvictor and kaydelaney and removed request for a team May 9, 2024 10:36
@Sergej-Vlasov Sergej-Vlasov mentioned this pull request May 9, 2024
Closed
@Sergej-Vlasov Sergej-Vlasov requested review from torkelo, axelavargas and ivanortegaalba and removed request for mdvictor May 9, 2024 10:47
@Sergej-Vlasov Sergej-Vlasov mentioned this pull request May 9, 2024
Merged
3 tasks
@Sergej-Vlasov
Copy link
Contributor Author

Closed in favour of #87561 to reduce complexity around hoverHeaderOffset

@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request May 14, 2024
Merged
3 tasks
@Sergej-Vlasov Sergej-Vlasov deleted the serge-fix-hover-header-in-scenes-lib-panels branch May 14, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

@kaydelaney kaydelaney Awaiting requested review from kaydelaney kaydelaney is a code owner automatically assigned from grafana/dashboards-squad

@torkelo torkelo Awaiting requested review from torkelo

@axelavargas axelavargas Awaiting requested review from axelavargas

@ivanortegaalba ivanortegaalba Awaiting requested review from ivanortegaalba

Assignees

@Sergej-Vlasov Sergej-Vlasov

Labels
area/frontend area/scenes internal for issues made by grafanistas no-changelog Skip including change in changelog/release notes type/bug
Projects
Dashboards
Status: 🚀 Done
Milestone
11.1.x
Development

Successfully merging this pull request may close these issues.

DashboardScene: Panel menu crop with hoverHeader in panel view/edit/duplicate/add scenarios
1 participant
@Sergej-Vlasov