Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11.0.x] Dashboard scene: Discard panel changes disabled/enabled depending of changes #87570

Merged
merged 4 commits into from
May 10, 2024
Merged

[v11.0.x] Dashboard scene: Discard panel changes disabled/enabled depending of changes #87570

merged 4 commits into from
May 10, 2024

Conversation

ivanortegaalba
Copy link
Contributor

Backport c3936bb from #87137

What is this feature?

Screen.Recording.2024-04-30.at.16.38.42.mov

This enables and disables the discard panel changes button depending on if the panel has been changed.

The comparison by converting to Panel and then running it through jsonDiff similar to what we do to detect dashboard changes might be a bit heavy handed, but it feels fairly robust.

Fixes #86974

@oscarkilhed @ivanortegaalba
DashboardScene: Discard panel changes disabled/enabled depending of c…
5b32681 
…hanges (#87137)

---------

Co-authored-by: Ivan Ortega Alba <ivanortegaalba@gmail.com>
Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
(cherry picked from commit c3936bb)
@ivanortegaalba ivanortegaalba added type/bug area/frontend backport A backport PR no-changelog Skip including change in changelog/release notes area/scenes labels May 9, 2024
@ivanortegaalba ivanortegaalba added this to the 11.0.x milestone May 9, 2024
@ivanortegaalba ivanortegaalba requested review from grafanabot and a team as code owners May 9, 2024 17:08
@ivanortegaalba ivanortegaalba requested review from mdvictor and kaydelaney and removed request for a team May 9, 2024 17:08
@grafanabot
Copy link
Contributor

❌ Failed to run Playwright plugin e2e tests.

Click here to browse the Playwright report and trace viewer.
For information on how to run Playwright tests locally, refer to the Developer guide.

@ivanortegaalba ivanortegaalba enabled auto-merge (squash) May 10, 2024 10:10
@ivanortegaalba ivanortegaalba merged commit e260d13 into v11.0.x May 10, 2024
11 checks passed
@ivanortegaalba ivanortegaalba deleted the backport-87137-to-v11.0.x branch May 10, 2024 11:41
@fabrizio-grafana fabrizio-grafana modified the milestones: 11.0.x, 11.0.0 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torkelo torkelo torkelo approved these changes

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

@mdvictor mdvictor Awaiting requested review from mdvictor mdvictor is a code owner automatically assigned from grafana/dashboards-squad

@kaydelaney kaydelaney Awaiting requested review from kaydelaney kaydelaney is a code owner automatically assigned from grafana/dashboards-squad

Assignees
No one assigned
Labels
area/frontend area/scenes backport A backport PR no-changelog Skip including change in changelog/release notes type/bug
Projects
Dashboards
Status: 🚀 Done
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ivanortegaalba @grafanabot @torkelo @fabrizio-grafana @oscarkilhed @gillesdemey