Dropdown: Fixes double call to onVisibilityChange #87607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
requested review from
joshhunt,
L-M-K-B and
ashharrison90
and removed request for
a team
torkelo
added
type/bug
no-backport
joshhunt
reviewed
May 10, 2024
joshhunt
approved these changes
May 10, 2024
ivanortegaalba
approved these changes
May 10, 2024
obetomuniz
added a commit
that referenced
this pull request
May 10, 2024
…-tracker * gops-configuration-tracker: (56 commits) SAML: add referemce to azure ad limitations (#87571) Update dependency glob to v10.3.14 Chore: Updated go.work.sum file (#87622) Update dependency @types/lodash to v4.17.1 (#87419) AdHocFilters: Use queries in ad hoc filters api calls (#87624) TimeSeries: Improve keyboard focus and fix spacebar override (#86848) Dropdown: Fixes double call to onVisibilityChange (#87607) [DOC] Adds missing link to Pyroscope core data source (#85493) Docs: Add Configuring Elasticsearch documentation for required privileges (#87593) Update dependency eslint-plugin-jsdoc to v48.2.4 Chore: Add login protection when user is trying different uppercase letters (#87588) Explore: lookup datasource by name when present in legacy URLs (#85222) Update dependency @prometheus-io/lezer-promql to v0.52.0 (#87554) Update dependency systemjs to v6.15.1 (#87594) Chore: Remove deprecated re-exported template variable types (#87459) Chore: Use getNextRefId instead of deprecated getNextRefIdChar (#87460) Chore: Remove use of deprecated method in AC code (#87541) Chore:: Update authlib version (#87603) Alerting: Reduce number of request fetching rules in the dashboard view using rtkq (#86991) refactor: rename variable ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed double calls to onVisbilityChange if that callback is not memoized (https://github.com/grafana/grafana/blob/main/public/app/features/dashboard-scene/scene/NavToolbarActions.tsx#L163)
While it should be memoized I do not think this double call behavior is not correct, the callback should only be called when the visibility changes not when the callback changes.
Using a ref for the callback fixes it, but there are probably other ways, not sure which is best.