Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Monitor: Basic Logs Backend #87653

Merged
merged 33 commits into from May 15, 2024

Conversation

aangelisc
Copy link
Contributor

What is this feature?

Adds backend support in Azure Monitor Logs service for the search API so that Basic Logs queries can be run from the front end

This PR also fixes a minor bug in the logic for showing the basic logs toggle that was causing the toggle to always reset to Analytics if the visualization was changed

Why do we need this feature?

For frontend Basic Logs implementation to work

Originally done by @jcolladokuri in #86404 but I broke that PR 😅

Fixes #84950 #84948 #84951

jcolladokuri and others added 28 commits April 16, 2024 03:19
Co-authored-by: Andreas Christou <andreas.christou@grafana.com>
Co-authored-by: Andreas Christou <andreas.christou@grafana.com>
Co-authored-by: Andreas Christou <andreas.christou@grafana.com>
…rce.go

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>
# Conflicts:
#	pkg/tsdb/azuremonitor/loganalytics/azure-log-analytics-datasource.go
#	pkg/tsdb/azuremonitor/loganalytics/azure-log-analytics-datasource_test.go
#	pkg/tsdb/azuremonitor/loganalytics/utils.go
#	public/app/plugins/datasource/azuremonitor/components/ConfigEditor/MonitorConfig.tsx
@aangelisc aangelisc added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels May 10, 2024
@aangelisc aangelisc added this to the 11.1.x milestone May 10, 2024
@aangelisc aangelisc requested a review from a team as a code owner May 10, 2024 17:16
@aangelisc aangelisc requested review from asimpson, bossinc, adamyeats and alyssabull and removed request for a team May 10, 2024 17:16
Copy link
Contributor

@asimpson asimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Just a nit of course 😏

@aangelisc aangelisc merged commit d82a807 into azure/basic-logs-support May 15, 2024
9 checks passed
@aangelisc aangelisc deleted the jck/azBasicLogs-backend branch May 15, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend area/frontend datasource/Azure Azure Monitor Datasource effort/medium no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants