New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Monitor: Basic Logs Backend #87653
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…basic logs or not
Co-authored-by: Andreas Christou <andreas.christou@grafana.com>
Co-authored-by: Andreas Christou <andreas.christou@grafana.com>
Co-authored-by: Andreas Christou <andreas.christou@grafana.com>
…rce.go Co-authored-by: Andreas Christou <andreas.christou@grafana.com>
# Conflicts: # pkg/tsdb/azuremonitor/loganalytics/azure-log-analytics-datasource.go # pkg/tsdb/azuremonitor/loganalytics/azure-log-analytics-datasource_test.go # pkg/tsdb/azuremonitor/loganalytics/utils.go # public/app/plugins/datasource/azuremonitor/components/ConfigEditor/MonitorConfig.tsx
aangelisc
added
no-backport
Skip backport of PR
no-changelog
Skip including change in changelog/release notes
labels
May 10, 2024
aangelisc
requested review from
asimpson,
bossinc,
adamyeats and
alyssabull
and removed request for
a team
May 10, 2024 17:16
grafana-pr-automation
bot
added
area/backend
datasource/Azure
Azure Monitor Datasource
area/frontend
labels
May 10, 2024
asimpson
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Just a nit of course 😏
public/app/plugins/datasource/azuremonitor/components/LogsQueryEditor/LogsQueryEditor.tsx
Outdated
Show resolved
Hide resolved
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/backend
area/frontend
datasource/Azure
Azure Monitor Datasource
effort/medium
no-backport
Skip backport of PR
no-changelog
Skip including change in changelog/release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Adds backend support in Azure Monitor Logs service for the
search
API so that Basic Logs queries can be run from the front endThis PR also fixes a minor bug in the logic for showing the basic logs toggle that was causing the toggle to always reset to Analytics if the visualization was changed
Why do we need this feature?
For frontend Basic Logs implementation to work
Originally done by @jcolladokuri in #86404 but I broke that PR 😅
Fixes #84950 #84948 #84951