New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loki: Kick start your query now applies templates to the current query #87658
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay for this! Left an idea bellow.
@@ -23,6 +23,27 @@ type Props = { | |||
onAddQuery?: (query: LokiQuery) => void; | |||
}; | |||
|
|||
const keepOperations: string[] = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a very good idea! I'll see if we can use that.
b3633d9
to
2470a8e
Compare
3f1f790
to
dc99417
Compare
This PR changes kick start your query to support keeping some of the pipe operations in the original query when the user chooses to replace the current query with a pattern.
To achieve that:
Work in combination with logs or metrics patterns.
Which issue(s) does this PR fix?:
Fixes #76207
Special notes for your reviewer:
Demo:
DEmo.mov