Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gops: Add tracking for data source check #87886

Merged
merged 1 commit into from
May 15, 2024
Merged

Gops: Add tracking for data source check #87886

merged 1 commit into from
May 15, 2024

Conversation

soniaAguilarPeiron
Copy link
Member

What is this feature?

This PR adds tracking for the alerting compatible data source check in the IRM configuration tracker.
I added the boolean to the generic track, as I think it can be interesting to know all the checks(done/not done) in every track.

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@soniaAguilarPeiron soniaAguilarPeiron added area/frontend add to changelog no-backport Skip backport of PR good cross gops-fe Share with a GOps Frontend dev on another focus labels May 15, 2024
@soniaAguilarPeiron soniaAguilarPeiron added this to the 11.1.x milestone May 15, 2024
@soniaAguilarPeiron soniaAguilarPeiron self-assigned this May 15, 2024
@soniaAguilarPeiron soniaAguilarPeiron requested a review from a team as a code owner May 15, 2024 07:03
@soniaAguilarPeiron soniaAguilarPeiron requested review from jtheory, gillesdemey, tomratcliffe and konrad147 and removed request for a team May 15, 2024 07:03
konrad147
konrad147 approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@konrad147 konrad147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@soniaAguilarPeiron soniaAguilarPeiron merged commit 28bf5a4 into main May 15, 2024
25 checks passed
@soniaAguilarPeiron soniaAguilarPeiron deleted the gops/add-tracking-for-datasources branch May 15, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konrad147 konrad147 konrad147 approved these changes

@jtheory jtheory Awaiting requested review from jtheory jtheory is a code owner automatically assigned from grafana/alerting-frontend

@gillesdemey gillesdemey Awaiting requested review from gillesdemey gillesdemey is a code owner automatically assigned from grafana/alerting-frontend

@tomratcliffe tomratcliffe Awaiting requested review from tomratcliffe tomratcliffe is a code owner automatically assigned from grafana/alerting-frontend

Assignees

@soniaAguilarPeiron soniaAguilarPeiron

Labels
add to changelog area/frontend good cross gops-fe Share with a GOps Frontend dev on another focus no-backport Skip backport of PR
Projects
None yet
Milestone
11.1.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@soniaAguilarPeiron @konrad147