Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alerting: Improve documentation regarding linking and visualizing alert rules in dashboards #87892

Merged
merged 2 commits into from
May 15, 2024

Conversation

tonypowa
Copy link
Contributor

@tonypowa tonypowa commented May 15, 2024

What is this feature?

Commit 1: https://grafana.com/docs/grafana/next/alerting/fundamentals/#alert-rules Mention linking dashboards to Alerts, and add shortcode to alerting demo dashboard in play

Commit 2: https://grafana.com/docs/grafana/next/alerting/fundamentals/alert-rule-evaluation/state-and-health/#alert-rule-state Add link to alerting demo dashboard in play to showcase alert rule state with the alert list panel and a panel that contains an alert (heart icon in the dashboard)

Commit 3: https://grafana.com/docs/grafana/next/alerting/alerting-rules/ mention the config option to link to existing panel and add link to alerting demo dashboard in play

Commit 4: https://grafana.com/docs/grafana/next/alerting/alerting-rules/create-grafana-managed-rule/#add-annotations edit the link to panel bit, and add link to alerting demo dashboard in play

Commit 5: https://grafana.com/docs/grafana/next/alerting/alerting-rules/create-mimir-loki-managed-rule/#add-annotations edit the link to panel bit, and add link to alerting demo dashboard in play

Why do we need this feature?

Improve documentation regarding linking and visualizing alert rules in dashboards by adding content to the docs above and showcase that feature by adding shortcode to link to play.grafana

@tonypowa tonypowa added type/docs no-changelog Skip including change in changelog/release notes backport v11.0.x Mark PR for automatic backport to v11.0.x labels May 15, 2024
@tonypowa tonypowa requested a review from brendamuir as a code owner May 15, 2024 08:42
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone May 15, 2024
Copy link
Contributor

This PR must be merged before a backport PR will be created.

1 similar comment
Copy link
Contributor

This PR must be merged before a backport PR will be created.

@tonypowa
Copy link
Contributor Author

@brendamuir
Commit 1 pushed -- will test it locally and update the ticket
Commits 2-5 will be added to this PR later

@tonypowa
Copy link
Contributor Author

done ✅
preview of each commit

let me know what you think @brendamuir @ppcano

commit 1
image

commit 2
image

commit 3
image

commit 4
image

commit 5
image

@@ -41,6 +41,10 @@ Add labels to uniquely identify your alert rule and configure alert routing. Lab

After alert rules are created, they go through various states and transitions.

You can also link alert rules to panels, allowing you to visualize the alert conditions directly within your dashboards and gain insights into the metrics triggering the alerts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am for Not mentioning Play in this section.

@@ -54,6 +54,12 @@ An alert instance can be in either of the following states:
| **NoData** | No data has been received for the configured time window. |
| **Error** | The error that occurred when attempting to evaluate an alert rule. |


Grafana provides an Alert List panel that allows you to visualize the states of different alert instances in a centralized view. By adding this panel to your dashboards, you can monitor which alerts are firing, pending, or inactive, enabling a comprehensive overview of your alerting landscape and facilitating quicker response times to any issues.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am for Not mentioning Play in this section.

@@ -43,6 +43,10 @@ How do you want your alert to be evaluated?

How do you want to route your alert? What kind of additional labels could you add to annotate your alert rules and ease searching?

In this section you also have the option to link an alert to a visualization.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am for Not mentioning Play in this section.

Copy link
Contributor

@ppcano ppcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think The Play admonition could fit well after the instruction Add a dashboard and panel link, but not convinced about including it in the other sections.

@tonypowa
Copy link
Contributor Author

done
waiting for approval @ppcano

@ppcano ppcano self-requested a review May 15, 2024 13:50
@tonypowa tonypowa merged commit e2f062d into main May 15, 2024
11 checks passed
@tonypowa tonypowa deleted the tonypowa/play branch May 15, 2024 13:50
grafana-delivery-bot bot pushed a commit that referenced this pull request May 15, 2024
…rt rules in dashboards (#87892)

* commit 4

* commit 5

(cherry picked from commit e2f062d)
tonypowa added a commit that referenced this pull request May 15, 2024
…lizing alert rules in dashboards (#87918)

alerting: Improve documentation regarding linking and visualizing alert rules in dashboards (#87892)

* commit 4

* commit 5

(cherry picked from commit e2f062d)

Co-authored-by: antonio <45235678+tonypowa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v11.0.x Mark PR for automatic backport to v11.0.x no-changelog Skip including change in changelog/release notes type/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants