Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Assume built-in AM is receiving alerts in case of not having admin config #87893

Merged
merged 5 commits into from
May 15, 2024

Conversation

soniaAguilarPeiron
Copy link
Member

What is this feature?

This PR fix the UI showing wrong status in the alerting settings page.

The problem:

When having a fresh Grafana instance:

  • admin_config is not set yet.
  • Grafana built in AM is the one receiving alerts.

The Bug: the UI was showing the built in AM as not receiving alerts.

Why do we need this feature?

We need to show a consistent status in the settings page.

Who is this feature for?

Admin users.

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@soniaAguilarPeiron soniaAguilarPeiron added this to the 11.1.x milestone May 15, 2024
@soniaAguilarPeiron soniaAguilarPeiron self-assigned this May 15, 2024
@soniaAguilarPeiron soniaAguilarPeiron requested a review from a team as a code owner May 15, 2024 09:41
@soniaAguilarPeiron soniaAguilarPeiron requested review from jtheory, gillesdemey, tomratcliffe and konrad147 and removed request for a team May 15, 2024 09:41
Copy link
Member

@gillesdemey gillesdemey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Sonia! 🚀

@gillesdemey gillesdemey merged commit 3aae2b7 into main May 15, 2024
14 checks passed
@gillesdemey gillesdemey deleted the alerting-fix-admin-settings-in-fresh-instance branch May 15, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants