[v11.0.x] Alerting: use logger with same context within rule scheduling loop #87936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
grafana-delivery-bot
bot
requested review from
jtheory and
rwwiv
and removed request for
a team
grafana-delivery-bot
bot
requested review from
JacobsonMT,
yuri-tceretian and
grobinson-grafana
grafana-delivery-bot
bot
added
area/backend
backport
yuri-tceretian
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport f410c7f from #87934
This fixes log message
https://github.com/grafana/grafana/blame/4b24019bae4f4a8bca9eb620e1afda49c5923ce4/pkg/services/ngalert/schedule/schedule.go#L293
that put rule UID into the message context with label "uid". However, everywhere else we use "rule_uid" label.
This PR makes all messages within the loop that schedules rule evaluations use the same logger with pre-loaded context.