-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AzureMonitor: Retrieve Azure clouds from SDK #87944
Conversation
…om a hard coded list
public/app/plugins/datasource/azuremonitor/components/ConfigEditor/AzureCredentialsForm.tsx
Show resolved
Hide resolved
import { DefaultSubscription } from './DefaultSubscription'; | ||
|
||
const legacyAzureClouds: SelectableValue[] = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we'll need to keep this const or migrate it to the SDK also
@aangelisc fixed some backend auth issues, and added some logic for merging the existing legacy cloud names with any custom cloud names, this should prevent the UI from being invalid for existing data sources |
public/app/plugins/datasource/azuremonitor/components/ConfigEditor/AzureCredentialsForm.tsx
Show resolved
Hide resolved
@aangelisc I added logic to normalize the cloud name in the front end. Can you take another look to make sure that this approach will work? |
…grate to the new format
…ck to getDefaultAzureCloud when not defined
* AzureMonitor: get the list of azure clouds from the SDK instead of from a hard coded list * add azure-sdk to yarn.lock * merge legacy with custom options * Normalize legacy cloud names * Workaround: send new credential format to backend while we wait to migrate to the new format * Lint fix * resolveLegacyCloudName should not return undefined * re-add undefined handling in resolveLegacyCloudName so that we fallback to getDefaultAzureCloud when not defined --------- Co-authored-by: Jeremy Angel <jeremyangel@microsoft.com> Co-authored-by: Andreas Christou <andreas.christou@grafana.com>
* AzureMonitor: get the list of azure clouds from the SDK instead of from a hard coded list * add azure-sdk to yarn.lock * merge legacy with custom options * Normalize legacy cloud names * Workaround: send new credential format to backend while we wait to migrate to the new format * Lint fix * resolveLegacyCloudName should not return undefined * re-add undefined handling in resolveLegacyCloudName so that we fallback to getDefaultAzureCloud when not defined --------- Co-authored-by: Jeremy Angel <jeremyangel@microsoft.com> Co-authored-by: Andreas Christou <andreas.christou@grafana.com>
What is this feature?
The Azure Monitor DS frontend currently has the list of azure clouds hard coded. This PR uses the grafana-azure-sdk-react package so that the list can be updated easily. Note: in this PR I am not yet moving from the AzureCredential class defined in the AzMon DS to the version of that class in the sdk - that will come in a later PR since it is lower priority.
Why do we need this feature?
This will allow Azure to easily add support for more clouds as they come online
Who is this feature for?
Azure Managed Grafana
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: