Chore: SCSS tidy up #87956
Merged
Chore: SCSS tidy up #87956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashharrison90
added
type/chore
no-backport
ashharrison90
requested review from
tskarhed,
L-M-K-B,
Ukochka,
dprokop and
kaydelaney
and removed request for
a team
Clarity-89
approved these changes
May 16, 2024
| @@ -9,9 +9,9 @@ interface Props { | |||
| const PageLoader = ({ pageName = '' }: Props) => { | |||
| const loadingText = `Loading ${pageName}...`; | |||
| return ( | |||
| <div className="page-loader-wrapper"> | |||
| <Box display="flex" alignItems="center" direction="column" justifyContent="center" paddingTop={10}> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
code_editor,panel_graphandpanel_piechartinto the_angular.scssfile so we can easily clean it up when angular is removedfilter-controlscompletely as it's unuseddashboard-settings__headerwith modern component equivalents and removesdashboard_settings.scssadmin-settings-sectionwith modern component equivalents and removespages/_admin.scsspage-loader-wrapperwith modern component equivalents and removescomponents/_page_loader.scssWhy do we need this feature?
Who is this feature for?
Which issue(s) does this PR fix?:
For #64129
Special notes for your reviewer:
Please check that: