Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K8s: Set X-Remote-Extra-User-Instance-Role header for SignedInUser #87958

Merged
merged 1 commit into from
May 16, 2024
Merged

K8s: Set X-Remote-Extra-User-Instance-Role header for SignedInUser #87958

merged 1 commit into from
May 16, 2024

Conversation

ferruvich
Copy link
Contributor

What is this feature?

Updating what has been done in #82543 - this PR adds X-Remote-Extra-User-Instance-Role header for the current Grafana user.

Why do we need this feature?

This is needed to forward additional user information to aggregated servers.

Which issue(s) does this PR fix?:

This PR has no related issue

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@ferruvich ferruvich added area/backend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels May 16, 2024
@ferruvich ferruvich self-assigned this May 16, 2024
@CLAassistant
Copy link

CLAassistant commented May 16, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone May 16, 2024
@ferruvich ferruvich marked this pull request as ready for review May 16, 2024 09:27
@ferruvich ferruvich requested a review from a team as a code owner May 16, 2024 09:27
radiohead
radiohead approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@radiohead radiohead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from cloud side 👍

@ferruvich
Copy link
Contributor Author

Thanks @ryantxu for the approval!
It seems I can't merge this as I need to be authorized, could you merge it when you have some time? Thanks!

@ryantxu ryantxu merged commit fbda553 into main May 16, 2024
23 checks passed
@ryantxu ryantxu deleted the ferruvich/set-k8s-req-headers-userrole branch May 16, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantxu ryantxu ryantxu approved these changes

@radiohead radiohead radiohead approved these changes

Assignees

@ferruvich ferruvich

Labels
area/backend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Milestone
11.1.x
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ferruvich @CLAassistant @ryantxu @radiohead