Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasources: Enable native histograms for datasource response size metric #87962

Merged
merged 1 commit into from
May 16, 2024

Conversation

marefr
Copy link
Member

@marefr marefr commented May 16, 2024

What is this feature?

Enables native histogram for the grafana_datasource_response_size_bytes metric.

If Prometheus feature flag native-histograms

  • is not enabled (default) everything will continue to work as today.
  • is enabled only the native histogram will be scraped and classic histograms ignored unless scrape of classic histogram is enabled in the scrape config then you'll get both the native and the classic ones scraped.

Why do we need this feature?

To be able to gather more valuable information about maximum/average response sizes. The current buckets only tracks up to 1MB and is to limited to understand what distribution goes between 1MB and infinity.

Who is this feature for?

Operators of Grafana.

Which issue(s) does this PR fix?:
Ref #35796

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@marefr marefr added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels May 16, 2024
@marefr marefr self-assigned this May 16, 2024
@marefr marefr requested review from a team as code owners May 16, 2024 10:20
@marefr marefr requested review from wbrowne, andresmgot, oshirohugo, bergquist and hairyhenderson and removed request for a team May 16, 2024 10:20
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone May 16, 2024
@marefr marefr modified the milestone: 11.1.x May 16, 2024
Copy link
Member

@xnyo xnyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link
Contributor

@bergquist bergquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marefr
Copy link
Member Author

marefr commented May 16, 2024

/deploy-to-hg

@ephemeral-instances-bot
Copy link

  • Preparing your instance. A comment containing your instance's url will be added to this PR when the instance is ready.
  • Your instance will be ready in ~10 minutes. Follow the workflow progress
  • Slack channel: #proj-ephemeral-hg-instances
  • Building instance with ds_response_size_native_hist oss branch and main enterprise branch. How to choose a branch

@ephemeral-instances-bot
Copy link

@marefr
Copy link
Member Author

marefr commented May 16, 2024

Seems to work as expected in ephemeral instance scraping both native and classic histogram 🎉

@marefr marefr merged commit 961272a into main May 16, 2024
23 checks passed
@marefr marefr deleted the ds_response_size_native_hist branch May 16, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants