Actionsets: cfg to only allow for actionsets as actions #87973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think the check here is in the right place. But I think instead of adding an onlyActionSets field to options for each resource, it might be better to just read that value form the config, and check if permission has prefix dashboards or folders before deciding whether to write the fine grained permissions or not.
eleijonmarck
requested review from
jtheory,
rwwiv,
JacobsonMT,
yuri-tceretian and
grobinson-grafana
and removed request for
a team
eleijonmarck
added
the
no-changelog
|
closing in favor of PR - #88367 this branch was not able to build enterprise properly |
eleijonmarck
deleted the
eleijonmarck/actionsets/cfg-only-access-action-sets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
This is an ongoing effort to have a option to only allow for actionsets to be written as part of the actionset work
This is to be able to test out actionsets as the only permissions to be set and used during expansion
what
OnlyAccessActionSetsto send through to thesetPermissionsQueryonlyactionsetstored.mov