Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grafana fundamentals fix #87975

Merged
merged 2 commits into from
May 16, 2024
Merged

grafana fundamentals fix #87975

merged 2 commits into from
May 16, 2024

Conversation

tonypowa
Copy link
Contributor

What is this feature?

  • updated instructions in the grafana fundamentals tutorial
  • restored older linking method because the dual linking method for oss and cloud isn't working in the tutorial

@tonypowa tonypowa added type/docs no-changelog Skip including change in changelog/release notes backport v11.0.x Mark PR for automatic backport to v11.0.x labels May 16, 2024
@tonypowa tonypowa requested a review from tomglenn May 16, 2024 11:38
@tonypowa tonypowa requested a review from Eve832 as a code owner May 16, 2024 11:38
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone May 16, 2024
@grafana-delivery-bot grafana-delivery-bot
Copy link
Contributor

This PR must be merged before a backport PR will be created.

1 similar comment
@grafana-delivery-bot grafana-delivery-bot
Copy link
Contributor

This PR must be merged before a backport PR will be created.

@tonypowa
Copy link
Contributor Author

tested locally and links work . Fingers crossed in prod it will work too!

mdcruz
mdcruz approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@mdcruz mdcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@tonypowa tonypowa merged commit c7d2a7a into main May 16, 2024
11 checks passed
@tonypowa tonypowa deleted the tonypowa/tutorial branch May 16, 2024 14:56
grafana-delivery-bot bot pushed a commit that referenced this pull request May 16, 2024
@tonypowa @grafana-delivery-bot
grafana fundamentals fix (#87975)
efddf1e 
* grafana fundamentals fix

* pretty face

(cherry picked from commit c7d2a7a)
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request May 16, 2024
Merged
tonypowa added a commit that referenced this pull request May 16, 2024
@grafana-delivery-bot @tonypowa
[v11.0.x] grafana fundamentals fix (#87992)
3ba9960 
grafana fundamentals fix (#87975)

* grafana fundamentals fix

* pretty face

(cherry picked from commit c7d2a7a)

Co-authored-by: antonio <45235678+tonypowa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdcruz mdcruz mdcruz approved these changes

@tomglenn tomglenn Awaiting requested review from tomglenn

@Eve832 Eve832 Awaiting requested review from Eve832 Eve832 is a code owner

Assignees
No one assigned
Labels
backport v11.0.x Mark PR for automatic backport to v11.0.x no-changelog Skip including change in changelog/release notes type/docs
Projects
None yet
Milestone
11.1.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tonypowa @mdcruz