Unified Storage: create kind_version table migration, add SQL and fix db #87977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegommm
added
go
diegommm
force-pushed
the
search-and-storage-issue-28-consistent-resource-version-proposal-1-pr3
branch
from
613933c
to
b5c8432
Compare
diegommm
commented
May 16, 2024
| @@ -0,0 +1,59 @@ | |||
| package dbimpl | |||
There was a problem hiding this comment.
We need these changes to be able to execute in different isolation levels.
diegommm
changed the title
| LIMIT 1 | ||
| {{ end }} | ||
|
|
||
| {{ if .SelectForUpdate }} |
There was a problem hiding this comment.
from pairing session: add no wait
There was a problem hiding this comment.
Will be added in the followup PR.
| ( | ||
| {{ .Ident "group" }}, | ||
| {{ .Ident "resource" }}, | ||
| {{ .Ident "resource_version" }} |
There was a problem hiding this comment.
from pairing session: possibly add updated_at
There was a problem hiding this comment.
Fixed! Added created_at as well for completeness, doesn't hurt and might be useful in the future. Note that I cannot add the proper DEFAULT to set the current timestamp because that is SQL-Dialect dependent, so I will change the corresponding SQL templates in the upcoming PRs.
chaudyg
approved these changes
May 22, 2024
diegommm
deleted the
search-and-storage-issue-28-consistent-resource-version-proposal-1-pr3
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
kind_versiontable.Why do we need this feature?
To implement Proposal 1 for Consistent Resource Version.
Who is this feature for?
Everyone
Which issue(s) does this PR fix?:
None
Special notes for your reviewer:
Please check that: