Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Skip flakey silencing test #87994

Merged
merged 1 commit into from
May 16, 2024

Conversation

tomratcliffe
Copy link
Member

@tomratcliffe tomratcliffe commented May 16, 2024

What is this feature?

Skips a flakey test

Why do we need this feature?

Sanity of everyone opening PRs 馃槍

Not sure why this is failing, as it passes locally for me. For now, will skip this one and work it out in Silencing RBAC work

For posterity; here's the output of a failed build from the flakey test
https://drone.grafana.net/grafana/grafana/178375/1/6

@tomratcliffe tomratcliffe requested a review from a team as a code owner May 16, 2024 15:33
@tomratcliffe tomratcliffe requested review from jtheory, gillesdemey, konrad147 and soniaAguilarPeiron and removed request for a team May 16, 2024 15:33
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone May 16, 2024
@tomratcliffe tomratcliffe added no-changelog Skip including change in changelog/release notes area/alerting Grafana Alerting labels May 16, 2024
@tomratcliffe tomratcliffe enabled auto-merge (squash) May 16, 2024 15:36
@tomratcliffe tomratcliffe merged commit 938fcab into main May 16, 2024
31 checks passed
@tomratcliffe tomratcliffe deleted the alerting/skip-silence-test-flakey branch May 16, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Grafana Alerting area/frontend no-changelog Skip including change in changelog/release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants