Alerting: separate out silence auth service preconditions checks #87998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobsonMT
added
area/alerting
JacobsonMT
requested review from
jtheory,
rwwiv,
yuri-tceretian and
grobinson-grafana
and removed request for
a team
Will be useful for subsequent PR that adds metadata to silence response
JacobsonMT
force-pushed
the
jacobsonmt/silence-ac-refactor
branch
from
1e93a64
to
ed8d0ff
Compare
JacobsonMT
commented
May 16, 2024
| user: newUser(), | ||
| expected: []*models.Silence{}, | ||
| expectedErr: ErrAuthorizationBase, |
There was a problem hiding this comment.
This is not actually a change, previously it was caught by middleware.
| hasAccess, err = s.HasAccess(ctx, user, readRuleSilenceEvaluator(ns)) | ||
| if err != nil { | ||
| return nil, err | ||
| hasAccess = s.authorizeReadSilence(ctx, user, silWithFolder) == nil |
There was a problem hiding this comment.
creation of the authz error is a bit more costly than regular error, I wonder if we can have just bool here. This is not a blocker, though.
yuri-tceretian
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be useful for subsequent PR that adds metadata to silence response
What is this feature?
Separates out precondition checks from silence auth service
AuthorizeXSilencemethods.Why do we need this feature?
This is so precondition checks can be used separately in a subsequent PR that will add permission metadata information to the GET silence responses.
Special notes for your reviewer:
This is mostly a no-op refactor but introduces a new short circuit for silence reads when a user has wildcard folder permissions.