Storage: Extract returned object hydration into function #88012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonorfmartins
added
the
no-changelog
DanCech
reviewed
May 20, 2024
suntala
changed the title
suntala
reviewed
May 21, 2024
3 tasks
suntala
approved these changes
May 22, 2024
leonorfmartins
force-pushed
the
dualwriter/labels_test
branch
2 times, most recently
from
dd70819
to
6d24f29
Compare
leonorfmartins
requested review from
joshhunt,
ashharrison90,
Ukochka,
wbrowne,
andresmgot and
xnyo
and removed request for
a team
Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com>
leonorfmartins
force-pushed
the
dualwriter/labels_test
branch
from
9ca60ca
to
2ae996c
Compare
leonorfmartins
removed request for
joshhunt,
ashharrison90,
Ukochka,
wbrowne,
andresmgot,
xnyo,
jtheory,
gillesdemey,
tomratcliffe,
konrad147 and
soniaAguilarPeiron
miguelmolina95
pushed a commit
to miguelmolina95/grafana
that referenced
this pull request
Jun 3, 2024
* Extract returned object hydration into function * Finish writing tests for utils func * Lint * Update pkg/apiserver/rest/dualwriter_mode2.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * Better var naming * Remove duplicated logic * Lint * Fix test * Lint * Make type private * Fix one more test * Fix test --------- Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
enrichObjectis called multiple times and holds some internal object of which fields should be overridden depending on the case.This PR extracts as much logic as possible into that functions and adds tests for it.
Why do we need this feature?
[Add a description of the problem the feature is trying to solve.]
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Part of https://github.com/grafana/search-and-storage-team/issues/5
Special notes for your reviewer:
Please check that: