Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Make dashboard search faster #88019

Merged

Conversation

knuzhdin
Copy link
Contributor

What is this feature?

This fix significantly reduces dashboard search time for large installations (tested with MySQL backend). Since all filters are collapsed by AND operator, the order does not matter for the result output, but greatly impacts the speed of the operation.

Why do we need this feature?

Suggestions and searches for dashboards especially for non-admin users become about x100 times faster. This is not so noticable for small installations. But for installations with ~50k dashboards, ~20k users and ~200k permissions is reduces search time from 5min to 0.3sec

Who is this feature for?

Everyone, who is searching dashboards by name on large installations (possibly only with MySQL backend)

Which issue(s) does this PR fix?:

Fixes #69659

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@knuzhdin knuzhdin requested a review from a team as a code owner May 17, 2024 14:37
@grafana-pr-automation grafana-pr-automation bot added area/backend pr/external This PR is from external contributor labels May 17, 2024
@knuzhdin
Copy link
Contributor Author

knuzhdin commented May 17, 2024

Same PR, bad author - #77161 - discussion here

Please check this PR @mckn @DanCech @zserge @RichiH

@DanCech DanCech added add to changelog no-backport Skip backport of PR labels May 20, 2024
@DanCech DanCech added this to the 11.1.x milestone May 20, 2024
@DanCech DanCech merged commit 28992f0 into grafana:main May 20, 2024
28 checks passed
@DanCech
Copy link
Collaborator

DanCech commented May 20, 2024

Merged! Thanks for all your efforts to get this over the line 🥇

@knuzhdin knuzhdin deleted the dashboard-search-accelerate-author-fix branch May 21, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/backend no-backport Skip backport of PR pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search: navigation bar search very slow for non-admins
2 participants