Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scopes: UI Improvements #88026

Merged
merged 30 commits into from
Jun 6, 2024
Merged

Scopes: UI Improvements #88026

merged 30 commits into from
Jun 6, 2024

Conversation

bfmatei
Copy link
Contributor

@bfmatei bfmatei commented May 17, 2024

What is this feature?

Implement the new UI for Scopes.

Why do we need this feature?

Have a proper UI for Scopes

Who is this feature for?

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Demo:

720p.mov

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@bfmatei bfmatei self-assigned this May 17, 2024
@bfmatei bfmatei requested review from a team as code owners May 17, 2024 18:18
@bfmatei bfmatei requested review from axelavargas and removed request for a team May 17, 2024 18:18
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone May 17, 2024
@bfmatei bfmatei added area/dashboard no-changelog Skip including change in changelog/release notes area/scopes scopes feature no-backport Skip backport of PR labels May 17, 2024
dprokop
dprokop reviewed May 23, 2024
View reviewed changes
Copy link
Member

@dprokop dprokop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've left some nits to consider. I suggest implementing some tests before landing this on main :)

public/app/features/dashboard-scene/scene/Scopes/ScopesFiltersBaseSelectorScene.tsx Outdated Show resolved Hide resolved
public/app/features/dashboard-scene/scene/Scopes/ScopesFiltersBasicSelectorScene.tsx Outdated Show resolved Hide resolved
public/app/features/dashboard-scene/scene/Scopes/ScopesFiltersScene.tsx Outdated Show resolved Hide resolved
@bfmatei bfmatei force-pushed the bogdan/scopes-ui-enhancements branch 2 times, most recently from 8fe4922 to 9e32096 Compare June 4, 2024 07:57
@bfmatei bfmatei requested review from a team as code owners June 4, 2024 07:57
@bfmatei bfmatei requested review from eledobleefe and sunker and removed request for a team June 4, 2024 07:57
@bfmatei bfmatei force-pushed the bogdan/scopes-ui-enhancements branch 3 times, most recently from 5b6d94f to 3cd27e9 Compare June 5, 2024 16:07
@bfmatei bfmatei mentioned this pull request Jun 5, 2024
Closed
3 tasks
@bfmatei bfmatei force-pushed the bogdan/scopes-ui-enhancements branch from 3a524b3 to 8507044 Compare June 6, 2024 08:05
@bfmatei bfmatei enabled auto-merge (squash) June 6, 2024 09:59
@bfmatei bfmatei requested a review from dprokop June 6, 2024 10:43
@bfmatei bfmatei merged commit 8d36949 into main Jun 6, 2024
19 of 20 checks passed
@bfmatei bfmatei deleted the bogdan/scopes-ui-enhancements branch June 6, 2024 14:00
kminehart pushed a commit that referenced this pull request Jun 10, 2024
@bfmatei @kminehart
Scopes: UI Improvements (#88026)
359f101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprokop dprokop dprokop approved these changes

@lukasztyrala lukasztyrala Awaiting requested review from lukasztyrala

@bergquist bergquist Awaiting requested review from bergquist

@kylebrandt kylebrandt Awaiting requested review from kylebrandt

@ashharrison90 ashharrison90 Awaiting requested review from ashharrison90

@Ijin08 Ijin08 Awaiting requested review from Ijin08

@axelavargas axelavargas Awaiting requested review from axelavargas axelavargas is a code owner automatically assigned from grafana/dashboards-squad

@eledobleefe eledobleefe Awaiting requested review from eledobleefe eledobleefe is a code owner automatically assigned from grafana/grafana-frontend-platform

@sunker sunker Awaiting requested review from sunker sunker is a code owner automatically assigned from grafana/plugins-platform-frontend

Assignees

@bfmatei bfmatei

Labels
area/dashboard area/frontend area/scopes scopes feature levitate breaking change A label indicating a breaking change and assigned by Levitate. no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Milestone
11.1.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bfmatei @dprokop