Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerting: Fix typo in JSON response for rule export. #88028

Merged
merged 1 commit into from
May 20, 2024
Merged

Alerting: Fix typo in JSON response for rule export. #88028

merged 1 commit into from
May 20, 2024

Conversation

yuri-tceretian
Copy link
Contributor

No description provided.

@yuri-tceretian yuri-tceretian added type/bug area/alerting Grafana Alerting add to changelog backport v11.0.x Mark PR for automatic backport to v11.0.x labels May 18, 2024
@yuri-tceretian yuri-tceretian requested a review from a team as a code owner May 18, 2024 00:42
@yuri-tceretian yuri-tceretian requested review from jtheory, rwwiv, JacobsonMT and grobinson-grafana and removed request for a team May 18, 2024 00:42
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone May 18, 2024
@grafana-delivery-bot grafana-delivery-bot
Copy link
Contributor

This PR must be merged before a backport PR will be created.

1 similar comment
@grafana-delivery-bot grafana-delivery-bot
Copy link
Contributor

This PR must be merged before a backport PR will be created.

ryantxu
ryantxu approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@ryantxu ryantxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will fixing this cause issues with existing code? If it is new code... any reason to use a *string vs an empty string? Same for panelID... there is no panelID zero

@yuri-tceretian
Copy link
Contributor Author

will fixing this cause issues with existing code?

No, this model is only used for export.

any reason to use a *string vs an empty string? Same for panelID...

I think the only reason in this particular case, is to distinguish between specified field or not specified. In this model it's not necessary, and used for simpler conversion logic between models.

@yuri-tceretian yuri-tceretian merged commit 8c2a382 into main May 20, 2024
25 checks passed
@yuri-tceretian yuri-tceretian deleted the yuri-tceretian/fix-typo-dashboard branch May 20, 2024 13:39
grafana-delivery-bot bot pushed a commit that referenced this pull request May 20, 2024
@yuri-tceretian @grafana-delivery-bot
Alerting: Fix typo in JSON response for rule export. (#88028)
b27832b 
(cherry picked from commit 8c2a382)
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request May 20, 2024
Merged
yuri-tceretian added a commit that referenced this pull request May 20, 2024
@grafana-delivery-bot @yuri-tceretian
[v11.0.x] Alerting: Fix typo in JSON response for rule export. (#88090)
f622370 
Alerting: Fix typo in JSON response for rule export. (#88028)

(cherry picked from commit 8c2a382)

Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>
grafana-delivery-bot bot pushed a commit that referenced this pull request May 20, 2024
@yuri-tceretian @grafana-delivery-bot
Alerting: Fix typo in JSON response for rule export. (#88028)
0574f52 
(cherry picked from commit 8c2a382)
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request May 20, 2024
Merged
yuri-tceretian added a commit that referenced this pull request May 20, 2024
@grafana-delivery-bot @yuri-tceretian
[v10.4.x] Alerting: Fix typo in JSON response for rule export. (#88094)
f063ee8 
Alerting: Fix typo in JSON response for rule export. (#88028)

(cherry picked from commit 8c2a382)

Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantxu ryantxu ryantxu approved these changes

@jtheory jtheory Awaiting requested review from jtheory jtheory was automatically assigned from grafana/alerting-backend-product

@rwwiv rwwiv Awaiting requested review from rwwiv rwwiv was automatically assigned from grafana/alerting-backend-product

@JacobsonMT JacobsonMT Awaiting requested review from JacobsonMT JacobsonMT was automatically assigned from grafana/alerting-backend-product

@grobinson-grafana grobinson-grafana Awaiting requested review from grobinson-grafana grobinson-grafana was automatically assigned from grafana/alerting-backend-product

Assignees
No one assigned
Labels
add to changelog area/alerting Grafana Alerting area/backend backport v10.4.x backport v11.0.x Mark PR for automatic backport to v11.0.x type/bug
Projects
Alerting
Status: Done
Milestone
11.1.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yuri-tceretian @ryantxu