New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide modals when pressing Esc, fixes #8988 #8994

Merged

torkelo merged 1 commit into grafana:v4.4.x from j-white:fix-hide-modals

Aug 7, 2017

Contributor

j-white commented Aug 6, 2017

This fixes the issue reported in #8988

We now send a hide-modal event, handled by UtilSrv to close the modal, rather than trying to close it directly in the KeybindingSrv.


          fix: hide modals when pressing Esc, fixes grafana#8988

torkelo merged commit f547c93 into grafana:v4.4.x

Member

torkelo commented Aug 7, 2017

thanks!

torkelo added this to the 4.4.3 milestone

ying-jeanne added the pr/external label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment