relax tests to be "within" instead of "equal", so they won't fail on i686 #9286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e "within" instead of "equal", so they won't fail on i686
|
|
ryantxu
added a commit
to NatelEnergy/grafana
that referenced
this pull request
Sep 20, 2017
* grafana/master: bug: enable HEAD requests again Add `DbClusterIdentifier` to CloudWatch dimensions (grafana#9297) templating: fix dependent variable updating (grafana#9306) Fix adhoc filters restoration (grafana#9303) Explicitly refer to Github 'OAuth' applications fixes bug introduced with prom namespaces fixing spelling of millesecond -> millisecond fixing spelling of millesecond -> millisecond Remove duplicate bus.AddHandler() (grafana#9289) Update CHANGELOG.md updated error page html+css, added ds_store to ignore (grafana#9285) public/app/plugins/panel/graph/specs/graph_specs.ts: relax tests to be "within" instead of "equal", so they won't fail on i686 (grafana#9286)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9264
This is ugly, I know, but it works.
However, I don't "speak" javascript and this was the minimal patch letting the tests pass on i686 (without simply removing them).
I'm open to suggestions for improvement, but honestly, I think, I'm not able to come up with something by myself, sry.