Stop offering a delete link for expiring previews #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only display a link to delete previews if they aren't set to expire.
rhowe
force-pushed
the
omit-delete-link
branch
from
fc7c02c
to
e93e8d7
Compare
|
@dsotirakis not wanting to bug, but how about this one? |
malcolmholmes
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only display a link to delete previews if they aren't set to expire.
It seems unnecessary to offer a manual delete link if the user has requested automatic deletion after an expiry time.
This should result in less UI clutter and fewer unintentional deletions from hitting the wrong link by accident.