Use absolute import paths #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsotirakis
approved these changes
Aug 16, 2021
|
The way this is written, if the path specified in opts.JsonnetPaths is already absolute (begins with "/"), this will still join with the cwd, resulting in an invalid path. I think this can be fixed by using testing for !filepath.IsAbs before doing the operation. |
|
@ywwg Fix a bug, add a bug... Thanks for the (valid) observation. Fancy rolling a quick PR? |
|
np: #156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to legacy support for hidden fields, Grizzly does not load Jsonnet files directly - it loads its own Jsonnet, which imports the referenced jsonnet.
This means that the path to the
libandvendordirectories will actually be the current directory, not the directory in which the loaded jsonnet file resides.This PR makes those paths absolute and relative to the jsonnet file's directory, and fixes this issue.