Add GetUID function to resource object #159
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new tests have shown up some naming issues.
We have
resource.Name()
, which extractsmetadata.name
, but this is notthe resource's UID, which in some cases needs to be a compound element, e.g.
$NAMESPACE.$NAME
for aPrometheusRuleGroup
or$TYPE.$JOB
for aSyntheticMonitoringCheck
.This PR adds a
GetUID()
function that correctly returns a UID across allresource types.