Set name metadata correctly for prom rules #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsotirakis
approved these changes
Aug 25, 2021
dsotirakis
reviewed
Aug 25, 2021
| @@ -52,7 +52,7 @@ func getRemoteRuleGroup(uid string) (*grizzly.Resource, error) { | |||
| "rules": group.Rules, | |||
| } | |||
| handler := RuleHandler{} | |||
| resource := grizzly.NewResource(handler.APIVersion(), handler.Kind(), uid, spec) | |||
| resource := grizzly.NewResource(handler.APIVersion(), handler.Kind(), group.Name, spec) | |||
There was a problem hiding this comment.
Reeeeeeeeally nit, but we can use name instead of group.Name since we have already extracted the var
|
fixed in a different PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here,
uidis$NAMESPACE.$NAME. We should not set thenameto that.Currently, if we re-render a UID we will get
$NAMESPACE.$NAMESPACE.$NAME.This PR corrects this error by setting the name to just
group.name. Thenamespace is set in metadata in the next line.