Always apply handlers in order #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malcolmholmes
commented
Aug 25, 2021
| NewRuleHandler(*p), | ||
| NewSyntheticMonitoringHandler(*p), | ||
| } |
There was a problem hiding this comment.
Datasources -> Folders -> Dashboards -> Prometheus Rules -> Synthetic Monitoring seems a reasonable order of precedence.
malcolmholmes
force-pushed
the
malcolmholmes/consistent-resource-ordering
branch
from
d8e02cc
to
cac0141
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grizzly consumes code from Tanka that extracts "manifests" from a
JSON tree (i.e. output from Jsonnet script). This is returned as a
map[string]manifest.Manifest. As this is a map, it is unordered,meaning resources are returned in a different order each time.
This can cause problems when ordering matters, notably when a
dashboard is applied before its folder.
This PR creates a consistent ordering for resources, they will
always be processed in consistent handler order.
Note, ordering within a handler will not (yet) be consistent, but
this shouldn't cause issues.