Set datasource spec.name to metadata.name #182
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #181
Resolves the following error when doing
grr apply grr.jsonnet
in the example folder:Non-200 response from Grafana while applying datasource prometheus: 422 Unprocessable Entity [{"fieldNames":["Name"],"classification":"RequiredError","message":"Required"}]
spec.name
seems to be a required datasource field. I think it makes sense to copy the name from metadata, as done withspec.uid
.