Improve Jpath handling #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsotirakis
approved these changes
Oct 21, 2021
| absolutePaths = append(absolutePaths, path) | ||
| jsonnetDir := filepath.Dir(jsonnetFile) | ||
| for _, p := range jpath { |
There was a problem hiding this comment.
This for loop can be merged with the next one, by setting a temp := p var and then append both?
There was a problem hiding this comment.
I did think of that at first. But I want to have the two dirs relative to the jsonnet file first, then the two relative to the current directory.
Duologic
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, we would have a way to track down the root of a project, and from there
identify where the default jsonnet paths of
libandvendorshould be found.In place of this, we need two forms:
local overrides of other imports
running Grizzly in the midst of other larger jsonnet codebases.
Without this fix, the Grizzly/Jsonnet examples don't work.