Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ioutil #187

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Replace ioutil #187

merged 2 commits into from
Oct 28, 2021

Conversation

julienduchesne
Copy link
Member

It is deprecated as of 1.16 (which grizzly uses): https://golang.org/doc/go1.16#ioutil
I also ran go mod tidy

@julienduchesne
Replace ioutil uses
9e9e9b5 
It is deprecated as of 1.16 (which grizzly uses): https://golang.org/doc/go1.16#ioutil
I also ran `go mod tidy`
@julienduchesne julienduchesne changed the title Replace ioutil uses Replace ioutil Oct 27, 2021
@julienduchesne julienduchesne marked this pull request as ready for review October 27, 2021 14:52
@julienduchesne julienduchesne requested review from malcolmholmes and a team October 27, 2021 14:52
the-it
the-it approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@the-it the-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jvrplmlmn
jvrplmlmn approved these changes Oct 27, 2021
View reviewed changes
Copy link
Collaborator

@jvrplmlmn jvrplmlmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the CI! 👍

malcolmholmes
malcolmholmes approved these changes Oct 28, 2021
View reviewed changes
Copy link
Collaborator

@malcolmholmes malcolmholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@julienduchesne julienduchesne merged commit 98137a8 into master Oct 28, 2021
@julienduchesne julienduchesne deleted the julienduchesne/ioutil-deprecated branch October 28, 2021 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvrplmlmn jvrplmlmn jvrplmlmn approved these changes

@the-it the-it the-it approved these changes

@malcolmholmes malcolmholmes malcolmholmes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@julienduchesne @jvrplmlmn @the-it @malcolmholmes