Add debug logging for most commands #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvrplmlmn
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
I've been thinking about doing something like this. This is extremely helpful. Thanks!
Could we, though, add the logging option configuration somehow to defaultGrizzlyFlags? I can imagine scenarios where we have other flags that need initialising too, so wrapping each xxxCmd() function could get problematic.
While debugging a failing apply, I thought some debug logging would be helpful This is very verbose for normal usecases so I also added a `--log-level` option to all commands to toggle the debug logging
julienduchesne
force-pushed
the
julienduchesne/add-debug-logging
branch
3 times, most recently
from
25ea783
to
210b972
Compare
julienduchesne
force-pushed
the
julienduchesne/add-debug-logging
branch
from
210b972
to
8590375
Compare
Done! |
malcolmholmes
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging a failing apply, I thought some debug logging would be helpful
This is very verbose for normal usecases so I also added a
--log-leveloption to all commands to toggle the debug logging