fix: Synthetic monitoring UIDs are wrong #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvrplmlmn
approved these changes
Oct 27, 2021
malcolmholmes
approved these changes
Oct 28, 2021
julienduchesne
force-pushed
the
julienduchesne/add-debug-logging
branch
4 times, most recently
from
210b972
to
8590375
Compare
julienduchesne
force-pushed
the
julienduchesne/fix-uid
branch
2 times, most recently
from
9355109
to
51523dc
Compare
The UID computed from the jsonnet definition uses a `.` as a separator while the one computed from the remote checks uses `-` as a separator This means that they never match and Grizzly always tries to create checks even if they already exists This fails with a `409 Conflict` error
julienduchesne
force-pushed
the
julienduchesne/fix-uid
branch
from
51523dc
to
bc31e7a
Compare
julienduchesne
changed the base branch from
julienduchesne/add-debug-logging
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UID computed from the jsonnet definition uses a
.as a separator while the one computed from the remote checks uses-as a separatorThis means that they never match and Grizzly always tries to create checks even if they already exists
This fails with a
409 Conflicterror