Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documenting the use of a proxy with grizzly #193

Merged
merged 2 commits into from
Dec 9, 2021
Merged

documenting the use of a proxy with grizzly #193

merged 2 commits into from
Dec 9, 2021

Conversation

gonzalez
Copy link
Contributor

@gonzalez gonzalez commented Dec 1, 2021

added the use of HTTPS_PROXY to our docs

@malcolmholmes
Copy link
Collaborator

does this actually work? I'm not aware of any HTTP proxy config within Grizzly.

@gonzalez
Copy link
Contributor Author

gonzalez commented Dec 7, 2021

Go checks for the environment variable and if it is set uses the proxy. I've tested this locally and my client has used it to migrate dashboards.

malcolmholmes
malcolmholmes approved these changes Dec 8, 2021
View reviewed changes
Copy link
Collaborator

@malcolmholmes malcolmholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification!

@gonzalez gonzalez merged commit 6c71679 into master Dec 9, 2021
@gonzalez gonzalez deleted the doc_proxy_update branch December 9, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malcolmholmes malcolmholmes malcolmholmes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gonzalez @malcolmholmes