Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix access to Grafana without any auth #210

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Fix access to Grafana without any auth #210

merged 1 commit into from
Apr 18, 2022

Conversation

v-zhuravlev
Copy link
Contributor

Here is the suggested fix for #209
to allow anonymous access to grafana.

@v-zhuravlev
Conditionally set Authorization token
cf11e5f 
Signed-off-by: Vitaly Zhuravlev <zhuravlev.vitaly@gmail.com>
@v-zhuravlev v-zhuravlev changed the title Fix access to Grafana when without any auth Fix access to Grafana without any auth Apr 16, 2022
malcolmholmes
malcolmholmes approved these changes Apr 18, 2022
View reviewed changes
Copy link
Collaborator

@malcolmholmes malcolmholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean and straightforward. Thanks for the patch.

@malcolmholmes malcolmholmes merged commit 76cf1f3 into master Apr 18, 2022
@v-zhuravlev v-zhuravlev deleted the vzhuravlev/conditional_token branch April 18, 2022 14:01
@v-zhuravlev v-zhuravlev mentioned this pull request Apr 18, 2022
Closed
@v-zhuravlev v-zhuravlev self-assigned this Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malcolmholmes malcolmholmes malcolmholmes approved these changes

Assignees

@v-zhuravlev v-zhuravlev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@v-zhuravlev @malcolmholmes