Add missing space in log message and docs update #212
Conversation
- Variables CORTEX_TENANT_ID, CORTEX_API_KEY are not mandatory - would work for cortex without authentication set - Remove cortextool requirement
v-zhuravlev
changed the title
docs/content/authentication.md
Outdated
| | `CORTEX_TENANT_ID` | Tenant ID for your Grafana Cloud Prometheus account | true | | ||
| | `CORTEX_API_KEY` | Authentication token/api key | true | | ||
| | `CORTEX_TENANT_ID` | Tenant ID for your Grafana Cloud Prometheus account | false | | ||
| | `CORTEX_API_KEY` | Authentication token/api key | false | |
There was a problem hiding this comment.
surely these are required to interact with Grafana Cloud Prometheus? Perhaps not for Cortex or Mimir alone though.
There was a problem hiding this comment.
Indeed, just thought if we are targeting standalone Cortex here as well, as mentioned below:
Note, this will also work with other Cortex installations, alongside Grafana Cloud Prometheus.
Not critical of course, maybe I should revert that.
There was a problem hiding this comment.
That is fine, but the words need to be valid: Grafana Cloud Prometheus requires creds, Cortex/Mimir don't. So long as it is clear, happy to have it in the docs.
There was a problem hiding this comment.
Decided to revert for now, not sure how to put it right, without making this page overcomplicated.
|
thanks! |
INFO[0069] Changes detected. Applyingdashboards.jsonnet
->
INFO[0069] Changes detected. Applying dashboards.jsonnet
Update cortex auth docs