-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Grafana Library Panels #218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
type LibraryPanelHandler struct { | ||
Provider Provider | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: a type assertion here would be nice to assert that LibraryPanelHandler
conforms to grizzly.Handler
.
So I pulled this down locally to try it out and I'm kind of caught in this catch 22 of both dashboards using the library panel and the library panel itself saying that it cannot be found. Steps for reproducing:
Dashboard apply always ends up with My guess would be that, when trying to I'm hoping I'm just missing something obvious, but figured it'd be beneficial to let you all know now before it's merged in case there is a further bug here. Let me know if I can add any more info. Grafana |
This is a reimplementation/follow up to #218, using the openapi client to keep in line with the rest of the codebase. It allows pull & push of library panels and variables. Tested pull & push with a simple library panel and a dashboard using this panel
This is a reimplementation/follow up to #218, using the openapi client to keep in line with the rest of the codebase. It allows pull & push of library panels and variables. Tested pull & push with a simple library panel and a dashboard using this panel
* feat: add support for library elements This is a reimplementation/follow up to #218, using the openapi client to keep in line with the rest of the codebase. It allows pull & push of library panels and variables. Tested pull & push with a simple library panel and a dashboard using this panel * fix: correctly order handlers
Resolved in #282 |
Adds support for Grafana library panels to Grizzly.
Also starts a transition to using the Golang client for Grafana. When
Grizzly was started, this was not sufficiently mature. This is no longer
the case. A transition to the golang client should reduce the amount
of code required in Grizzly.