Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding logic to handle grafana alerting ruler type #221

Conversation

mikkergimenez
Copy link

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Mikker Gimenez-Peterson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@malcolmholmes
Copy link
Collaborator

Hi. Curious how come you closed this PR. Looks interesting.

@mikkergimenez
Copy link
Author

Hello @malcolmholmes Closed because it's not polished ready for primetime, but happy to re-open it to work out in the open on it. I am ready for some kinda feedback as to whether or not this is heading in the right direction, some of it feels a bit hacky.

@malcolmholmes
Copy link
Collaborator

I really want to see this in Grizzly! Looking at your impl, it looked reasonable. However, if I were to do it now, I would use the grafana api golang client which now has support for alerts. A PR for library panels in Grizzly uses the client. Could you make that work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants