Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration: Add utility to run the same test on multiple contexts #323

Merged
merged 1 commit into from Feb 2, 2024

Conversation

julienduchesne
Copy link
Member

@julienduchesne julienduchesne commented Feb 1, 2024

Closes #26

To verify issues like above, we need to be able to test with various auth methods
This PR adds a basic_auth context (and instance) and adds the functionality to run the same test on all contexts. Running the same tests lots of times on various set-ups is also a good way to find flaky features

Also, I changed from the RunTests function to individual t.Run. This is helpful because vscode can now see the individual tests and we can run them individually

See run test | debug test buttons in the follow screenshot
image

@julienduchesne julienduchesne marked this pull request as ready for review February 1, 2024 19:00
@julienduchesne julienduchesne requested a review from a team as a code owner February 1, 2024 19:00
@julienduchesne julienduchesne linked an issue Feb 1, 2024 that may be closed by this pull request
Base automatically changed from julienduchesne/fix-subpath to main February 1, 2024 23:00
@julienduchesne julienduchesne force-pushed the julienduchesne/run-on-all-contexts branch from cd4b9d9 to f4cfab0 Compare February 1, 2024 23:01
Issue: #26

To verify issues like above, we need to be able to test with various auth methods
This adds a `basic_auth` context (and instance) and adds the functionality to run the same test on all contexts

Also, I changed from the `RunTests` function to individual t.Run. This is helpful because vscode can now see the individual tests and we can run them individually
@julienduchesne julienduchesne force-pushed the julienduchesne/run-on-all-contexts branch from f4cfab0 to 948a01a Compare February 1, 2024 23:13
julienduchesne added a commit that referenced this pull request Feb 2, 2024
Builds upon the test contexts added here: #323

Closes #104
This PR adds an integration test that an appropriate message is shown when invalid auth is provided. I needed to update the client because the errors were not showing up correctly in the current version
Copy link
Collaborator

@malcolmholmes malcolmholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@julienduchesne julienduchesne merged commit 73bf6ed into main Feb 2, 2024
7 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/run-on-all-contexts branch February 2, 2024 15:36
julienduchesne added a commit that referenced this pull request Feb 2, 2024
Builds upon the test contexts added here: #323

Closes #104
This PR adds an integration test that an appropriate message is shown when invalid auth is provided. I needed to update the client because the errors were not showing up correctly in the current version
julienduchesne added a commit that referenced this pull request Feb 2, 2024
Builds upon the test contexts added here: #323

Closes #104
This PR adds an integration test that an appropriate message is shown when invalid auth is provided. I needed to update the client because the errors were not showing up correctly in the current version
julienduchesne added a commit that referenced this pull request Feb 5, 2024
Builds upon the test contexts added here: #323

Closes #104
This PR adds an integration test that an appropriate message is shown when invalid auth is provided. I needed to update the client because the errors were not showing up correctly in the current version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP 401 Unauthorized
2 participants