-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration: Add utility to run the same test on multiple contexts #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
julienduchesne
force-pushed
the
julienduchesne/run-on-all-contexts
branch
from
February 1, 2024 23:01
cd4b9d9
to
f4cfab0
Compare
Issue: #26 To verify issues like above, we need to be able to test with various auth methods This adds a `basic_auth` context (and instance) and adds the functionality to run the same test on all contexts Also, I changed from the `RunTests` function to individual t.Run. This is helpful because vscode can now see the individual tests and we can run them individually
julienduchesne
force-pushed
the
julienduchesne/run-on-all-contexts
branch
from
February 1, 2024 23:13
f4cfab0
to
948a01a
Compare
malcolmholmes
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26
To verify issues like above, we need to be able to test with various auth methods
This PR adds a
basic_auth
context (and instance) and adds the functionality to run the same test on all contexts. Running the same tests lots of times on various set-ups is also a good way to find flaky featuresAlso, I changed from the
RunTests
function to individual t.Run. This is helpful because vscode can now see the individual tests and we can run them individuallySee
run test | debug test
buttons in the follow screenshot